add ecdf comparison plot #2178
Open
add ecdf comparison plot #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to be a mistake with the computation of the band |
|
IIRC, we merged this quickly from the GSOC work but didn't advertise it so that we could improve it before doing so. It also uses random sampling for the bands, which is quite slow, while the paper includes a deterministic approach for generating the bands. |
|
do you remember the main issues @sethaxen ? If so, could you open an issue? |
No, I don't, I'm sorry. And looking back through Slack and GitHub, I'm not seeing the discussions that I thought I remembered. I can open an issue about performance of the confidence band computation though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aiming to add a new example of ecdf comparison but the band computation seems to have a bug.
Checklist
section of the changelog?
📚 Documentation preview 📚: https://arviz--2178.org.readthedocs.build/en/2178/